Add allocations toolbox with allocate relationship item #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
|
Hi @marek-piirikivi, great idea to add an allocate relationship! I looked at other tools, and it looks like they put this relationship in the General or Common toolbox. Right now, it looks a little funny to have a single tool in a toolbox by itself. Should we put it in the General one and then split off the toolbox if needed later? |
|
Hi @danyeaw ! I thought about this. It is definitely doable. May need some merging logic though because general toolbox is put together in some other place, not SysML, but allocate is SysML concept. I'll think it's easy to do. Give me a day, I'll try to update within a day. |
|
I forgot that our common toolbox was common across languages. I think it is ok how you have it then. |
danyeaw
added
feature
|
Thanks @marek-piirikivi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds allocate relationship item to form generic allocation relationships between the elements
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2087
What is the new behavior?
Adds "Allocations" toolbox - conforms with the SysML document structure where it is a separate chapter. Adds ability to drag allocate relationships between two elements.
Does this PR introduce a breaking change?
Other information
The toolbox is only a single item, but in the future, we can add additional allocate notations. There are many ways to describe allocation in SysML.