Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allocations toolbox with allocate relationship item #2868

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

marek-piirikivi
Copy link
Contributor

Adds allocate relationship item to form generic allocation relationships between the elements

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #2087

What is the new behavior?

Adds "Allocations" toolbox - conforms with the SysML document structure where it is a separate chapter. Adds ability to drag allocate relationships between two elements.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The toolbox is only a single item, but in the future, we can add additional allocate notations. There are many ways to describe allocation in SysML.

@github-actions github-actions bot added python Pull requests that update Python code documentation labels Nov 26, 2023
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danyeaw
Copy link
Member

danyeaw commented Nov 26, 2023

Hi @marek-piirikivi, great idea to add an allocate relationship!

I looked at other tools, and it looks like they put this relationship in the General or Common toolbox. Right now, it looks a little funny to have a single tool in a toolbox by itself. Should we put it in the General one and then split off the toolbox if needed later?

@marek-piirikivi
Copy link
Contributor Author

Hi @danyeaw !

I thought about this. It is definitely doable. May need some merging logic though because general toolbox is put together in some other place, not SysML, but allocate is SysML concept. I'll think it's easy to do. Give me a day, I'll try to update within a day.

@danyeaw
Copy link
Member

danyeaw commented Nov 27, 2023

I forgot that our common toolbox was common across languages. I think it is ok how you have it then.

@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code documentation labels Nov 27, 2023
@danyeaw danyeaw merged commit 13bcd07 into gaphor:main Nov 27, 2023
20 checks passed
@danyeaw
Copy link
Member

danyeaw commented Nov 27, 2023

Thanks @marek-piirikivi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants