Make bot respond to api requests without waiting for discord. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current uses of the bot don't require waiting for a response from discord that the message has been sent. This PR changes the default behaviour of api routes to respond with a
202 Createdright after a request to send a message to discord has started without waiting for it to complete. An additional, optional, boolean parameterincludeDetailscan be passed in the JSON body of the request if the caller requires to wait for the discord message to be created and receive the id of the created message back.An additional change made in this PR is that the errorHandler middleware now logs the errors using
console.error(to be replaced with winston) and it responds to the client with the error only after checkingres.headersSendi.e. it won't sent a response if a route has already done so.TODO