This repository has been archived by the owner on Apr 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfranzke
reviewed
Jan 10, 2020
rfranzke
reviewed
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the whole code in detail, but in generally looks OK. Thanks! 👍
Can you rebase again to resolve the conflicts, please? |
rfranzke
suggested changes
Jan 20, 2020
...s/provider-vsphere/charts/internal/machine-controller-manager/seed/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
...s/internal/shoot-system-components/charts/csi-vsphere/templates/vsphere-csi-syncer-rbac.yaml
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/apis/vsphere/types_cloudprofile.go
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/apis/vsphere/v1alpha1/types_cloudprofile.go
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/controller/controlplane/valuesprovider.go
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go
Outdated
Show resolved
Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go
Outdated
Show resolved
Hide resolved
…f garden.sapcloud.io)
Removed InfrastructureConfig network.
rfranzke
approved these changes
Jan 20, 2020
I hope our own development guidelines will be applied in the future. |
rfranzke
added a commit
to gardener/gardener-extension-provider-vsphere
that referenced
this pull request
Jan 31, 2020
``` noteworthy operator Initial contribution of vSphere extension controller for Gardener (originally contributed by @MartinWeindel via [gardener-attic/gardener-extensions#537](https://github.com/gardener/gardener-extensions#537)) ``` ``` noteworthy developer github.com/gardener/terraformer #33 @DockToFuture The Google provider plugins have been upgraded to `v3.4.0`. ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/vmware
VMware platform/infrastructure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains the proof-of-concept infrastructure provider for VMware vSphere (with NSX-T).
etcd backup support(Backup with MinIO will be handled in a separate PR)Before we consider merge: