Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

provider-vsphere #537

Merged
merged 15 commits into from
Jan 20, 2020
Merged

provider-vsphere #537

merged 15 commits into from
Jan 20, 2020

Conversation

MartinWeindel
Copy link
Contributor

@MartinWeindel MartinWeindel commented Jan 10, 2020 •
edited

What this PR does / why we need it:
This PR contains the proof-of-concept infrastructure provider for VMware vSphere (with NSX-T).

  • Control plane controller
  • Control plane web hook
  • Infrastructure controller
  • Worker controller
  • etcd backup support (Backup with MinIO will be handled in a separate PR)

Before we consider merge:

@MartinWeindel MartinWeindel requested a review from a team as a code owner January 10, 2020 15:39
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2020
@MartinWeindel
Copy link
Contributor Author

Needs gardener/machine-controller-manager#384

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2020
@rfranzke rfranzke added the platform/vmware VMware platform/infrastructure label Jan 10, 2020
rfranzke
rfranzke reviewed Jan 10, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2020
rfranzke
rfranzke reviewed Jan 13, 2020
View reviewed changes
Copy link
Contributor

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the whole code in detail, but in generally looks OK. Thanks! 👍

controllers/provider-vsphere/README.md Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 17, 2020
@rfranzke
Copy link
Contributor

Can you rebase again to resolve the conflicts, please?

@rfranzke
Copy link
Contributor

Once this PR is merged, can you work on another PR similar to #557 and #438?

rfranzke
rfranzke suggested changes Jan 20, 2020
View reviewed changes
...s/provider-vsphere/charts/internal/machine-controller-manager/seed/templates/deployment.yaml Outdated Show resolved Hide resolved
...s/internal/shoot-system-components/charts/csi-vsphere/templates/vsphere-csi-syncer-rbac.yaml Outdated Show resolved Hide resolved
controllers/provider-vsphere/charts/provider-vsphere/values.yaml Show resolved Hide resolved
controllers/provider-vsphere/pkg/apis/vsphere/types_cloudprofile.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/apis/vsphere/v1alpha1/types_cloudprofile.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/controller/controlplane/valuesprovider.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/controller/worker/actuator.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
controllers/provider-vsphere/pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
@MartinWeindel
[WIP] provider-vsphere
8ad7c90
@MartinWeindel
remove webhook controlplanebackup
e324780
@MartinWeindel
revendoring and cleanup
fda0b9f
@MartinWeindel
revendor
3e5c3bd
@MartinWeindel
tweaking docu
39d69e3
@MartinWeindel
updated to nsxt-lb-provider-manager v0.2.0
64da9de
@MartinWeindel
updated tag and source repository for the machine-controller-manager …
2446695 
…image
@MartinWeindel
updated source repository for vsphere-csi-controller
d2e5f60
@MartinWeindel
fix check errors
f14d799
@MartinWeindel
allow to specify load balancer classes with ippool in the controlplan…
a106935 
…e config
@MartinWeindel
changes related to review (cleanup and using gardener.cloud instead o…
f89d928 
…f garden.sapcloud.io)
@MartinWeindel
Added tests for controlplane validation and CollectDataset.
d136d05 
Removed InfrastructureConfig network.
@MartinWeindel
revendor after rebasing
d98c601
@MartinWeindel
fixing optional parameters in api types, fixing CSI inconsistencies
1f7fd82
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 20, 2020
@rfranzke rfranzke merged commit 9370ec6 into gardener-attic:master Jan 20, 2020
@vpnachev
Copy link
Contributor

I hope our own development guidelines will be applied in the future.

rfranzke added a commit to gardener/gardener-extension-provider-vsphere that referenced this pull request Jan 31, 2020
@rfranzke
Empty commit transporting the release notes after repository split
959152f 
``` noteworthy operator
Initial contribution of vSphere extension controller for Gardener (originally contributed by @MartinWeindel via [gardener-attic/gardener-extensions#537](https://github.com/gardener/gardener-extensions#537))
```

``` noteworthy developer github.com/gardener/terraformer #33 @DockToFuture
The Google provider plugins have been upgraded to `v3.4.0`.
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/vmware VMware platform/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MartinWeindel @rfranzke @vpnachev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3