Fix infinite deadline for machineDeployment fetch/update #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshu-kun
requested review from
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
the
size/s
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
This was referenced May 9, 2023
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring * fixed unwanted rebase changes * Modifying taint removal logic on startup to consider all nodes instead of ready nodes. --------- Co-authored-by: Clint Fooken <clfooken@ea.com>
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring * Modifying taint removal logic on startup to consider all nodes instead of ready nodes. --------- Co-authored-by: Clint Fooken <clfooken@ea.com>
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring * Modifying taint removal logic on startup to consider all nodes instead of ready nodes. --------- Co-authored-by: Clint Fooken <clfooken@ea.com>
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring * Modifying taint removal logic on startup to consider all nodes instead of ready nodes. --------- Co-authored-by: Clint Fooken <clfooken@ea.com>
rishabh-11
pushed a commit
that referenced
this pull request
May 9, 2023
* retry deadline respected * reverted retryTimeout changed for testing * updated getMachineDeploymentUntilDeadline fn implementation and docstring * Modifying taint removal logic on startup to consider all nodes instead of ready nodes. --------- Co-authored-by: Clint Fooken <clfooken@ea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #213
Special notes for your reviewer:
Release note: