Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync upstream v1.29.2 #302

Merged
merged 1,056 commits into from
May 21, 2024
Merged

Sync upstream v1.29.2 #302

merged 1,056 commits into from
May 21, 2024

Conversation

sssash18
Copy link

@sssash18 sssash18 commented Apr 24, 2024 •
edited by rishabh-11
Loading

What this PR does / why we need it:
Sync with upstream autoscaler v1.29.2

Which issue(s) this PR fixes:
Fixes #275

Special notes for your reviewer:

Release note:

- Synced changes till v1.29.2 of upstream autoscaler.
- Updated the log level of some pod scheduling logs for better debugging.

dlipovetsky and others added 30 commits October 9, 2023 08:10
@dlipovetsky
clusterapi: Add 'watch' verb to scale-from-zero example
60fcea2 
If the 'get' and 'list' verbs are present, but the 'watch' verb is
absent, the autoscaler reports an error. For example:

cluster-autoscaler-b8949d8b9-76vcd E1006 22:11:43.056176       1
reflector.go:148]
k8s.io/client-go/dynamic/dynamicinformer/informer.go:108: Failed to
watch infrastructure.cluster.x-k8s.io/v1beta2,
Resource=vcdmachinetemplates: unknown
@k8s-ci-robot
Merge pull request kubernetes#6179 from dlipovetsky/master
834ec22 
clusterapi: Add 'watch' verb to scale-from-zero example
@k8s-ci-robot
Merge pull request kubernetes#6165 from pohly/binpacking-fix
bc0e288 
autoscaler: fix premature end of binpacking
@k8s-ci-robot
Merge pull request kubernetes#6178 from kubernetes/dependabot/docker/…
d7d33c7 
…vertical-pod-autoscaler/builder/golang-1.21.2

Bump golang from 1.21.1 to 1.21.2 in /vertical-pod-autoscaler/builder
@k8s-ci-robot
Merge pull request kubernetes#6140 from alphajc/master
07df121 
feat(tencentcloud): remove dependency on tke interface
@k8s-ci-robot
Merge pull request kubernetes#6183 from dbonfigli/dbonfigli-owner
e6ebe87 
Updated the owners of externalgrpc cloudprovider
@k8s-ci-robot
Merge pull request kubernetes#6134 from jackfrancis/azure-manager-env-ut
e7bf3ec 
Azure: add ENV coverage to UT
@ROunofF
Update with make generate
1fee557
@artemvmin
Add pdb filtering to remainingPdbTracker
7cb08df
@artemvmin
Convert replicated, system, not-safe-to-evict, and local storage pods…
125e9c1 
… to drainability rules
@artemvmin
Convert scale-down pdb check to drainability rule
d6ee96d
@artemvmin
Pass DeleteOptions once during default rule creation
324a33e
@artemvmin
Split out custom controller and common checks into separate drainabil…
2fa6c26 
…ity rules
@artemvmin
Filter out disabled drainability rules during creation
96e67ee
@artemvmin
Refactor GetPodsForDeletion logic and tests into simulator
084264c
@artemvmin
Fix custom controller drainability rule and add test coverage
9a7459c
@artemvmin
Add unit test for long-terminating pod past grace period
33e300f
@k8s-ci-robot
Merge pull request kubernetes#6164 from artemvmin/scale-down-drainabi…
133fdc7 
…lity

Convert scale-down checks to drainability rules
@dumlutimuralp
Removed node drainer, kept node termination handler
48b481b
@k8s-ci-robot
Merge pull request kubernetes#6185 from ROunofF/master
5c65c39 
Update ec2_instance_types with make generate
@hbostan
Add HasNodeGroupStartedScaleUp to cluster state registry.
833e4cb 
- HasNodeGroupStartedScaleUp checks wheter a scale up request exists
  without checking any upcoming nodes.
@k8s-ci-robot
Merge pull request kubernetes#6169 from hbostan/master
3065285 
Add HasNodeGroupStartedScaleUp to cluster state registry.
@rsgowman
Add kwiesmueller to OWNERS
f115964 
jbartosik et al are transitioning off of workload autoscalers (incl vpa
and addon-resizer). kwiesmueller is on the new team and has agreed to
take on reviewer/approver responsibilities.
@k8s-ci-robot
Merge pull request kubernetes#6198 from rsgowman/rsgowman/owners
3899147 
Add kwiesmueller to OWNERS
@kisieland
Add information about provisioning-class-name annotation.
79c1ff4
@k8s-ci-robot
Merge pull request kubernetes#6197 from kisieland/prov-req-annotation…
cc888a1 
…-fix

Add information about provisioning-class-name annotation.
@mikutas
Remove redundant if branch
e56c2d8
@k8s-ci-robot
Merge pull request kubernetes#6157 from mikutas/6156-informer
dab41cc 
Fix multiple run of informers created in fetcher.go
@artemvmin
Add mechanism to override drainability status
87013c2
@artemvmin
Log drainability override
a0d56b3
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 10, 2024
aaronfern
aaronfern approved these changes May 10, 2024
View reviewed changes
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
/lgtm

/second-opinion @rishabh-11

@gardener-robot gardener-robot removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels May 10, 2024
@aaronfern aaronfern added the needs/second-opinion Needs second review by someone else label May 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 14, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 21, 2024
rishabh-11
rishabh-11 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels May 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 21, 2024
@rishabh-11 rishabh-11 changed the title Sync upstream v1.29.0 Sync upstream v1.29.2 May 21, 2024
@rishabh-11 rishabh-11 merged commit 73b5bfe into gardener:machine-controller-manager-provider May 21, 2024
9 of 10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 left review comments

@aaronfern aaronfern aaronfern approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun himanshu-kun is a code owner

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@sssash18 sssash18

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync with Upstream v1.29.0