Add support for build metadata in version string #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
needs/review
6 tasks
gardener-robot-ci-3
added
needs/ok-to-test
ccwienk
reviewed
Jul 1, 2024
8R0WNI3
force-pushed
the
8R0WNI3-build-metadata
branch
from
a62fc72
to
232dd6b
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
size/s
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
8R0WNI3
force-pushed
the
8R0WNI3-build-metadata
branch
from
232dd6b
to
c5b6cd4
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
ccwienk
reviewed
Jul 1, 2024
8R0WNI3
force-pushed
the
8R0WNI3-build-metadata
branch
from
c5b6cd4
to
2dde084
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
ccwienk
reviewed
Jul 2, 2024
8R0WNI3
force-pushed
the
8R0WNI3-build-metadata
branch
from
2dde084
to
18116b6
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
@8R0WNI3 You need rebase this pull request with latest master branch. Please check. |
ccwienk
approved these changes
Jul 3, 2024
To be compatible with SemVer, we should be able to handle versions which include optional build metadata ([see](https://semver.org/#spec-item-10)). In general, this is already the case. However, (some) OCI registries don't allow `+` in their tags, which is used as separator for these build metadata. That's why, the version has to be sanitised prior to uploading to a registry or after retrieving it from there.
8R0WNI3
force-pushed
the
8R0WNI3-build-metadata
branch
from
18116b6
to
f14f445
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To be compatible with SemVer, we should be able to handle versions which include optional build metadata
(see). In general, this is already the case. However, (some) OCI registries don't allow
+in their tags, which is used as separator for these build metadata. That's why, the version has to be sanitised prior to uploading to a registry or after retrieving it from there.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: