fix: properly validate uniqueness of resource-names #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
needs/review
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
8R0WNI3
requested changes
Jul 2, 2024
Remove old codepath, originally intended for kaniko (+ remove check for extra-push-target, which was a limitation for (removed) kaniko-builder). Instead, validate uniqueness of resource-names.
It is a common pattern to have helmcharts corresponding to OciImages. Add helmcharts' types to extraIdentity to allow usage of equal names for pairs of images and helmcharts.
ccwienk
force-pushed
the
validate-resource-name-uniqueness
branch
from
a565a35
to
5ac181c
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
8R0WNI3
approved these changes
Jul 2, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old codepath, originally intended for kaniko (+ remove check for extra-push-target, which was a limitation for (removed) kaniko-builder). Instead, validate uniqueness of resource-names.