Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable followCNAME by default again #140

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Disable followCNAME by default again #140

merged 1 commit into from
Sep 1, 2023

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Sep 1, 2023 •
edited
Loading

What this PR does / why we need it:
Disable followCNAME by default again, as it was introduced with github.com/go-acme/lego version upgrade from v4.8.0 to v4.14.0(Introduced with go-acme/lego#1718)

Which issue(s) this PR fixes:
Fixes #139

Special notes for your reviewer:

Release note:

Disable followCNAME by default again as it was activated implicitly by github.com/go-acme/lego version upgrade

@MartinWeindel MartinWeindel requested a review from a team as a code owner September 1, 2023 09:32
@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2023
@MartinWeindel MartinWeindel merged commit dbb5d45 into master Sep 1, 2023
7 checks passed
@MartinWeindel MartinWeindel deleted the fix/disable-follow-cname branch September 1, 2023 09:38
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix FollowCNAME to be disabled by default
3 participants
@MartinWeindel @gardener-robot-ci-2 @gardener-robot