Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment specific default values for private key algorithm and size #171

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Deployment specific default values for private key algorithm and size #171

merged 1 commit into from
Apr 19, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Support deployment specific default values for private key algorithm and size with the new command line options --default-private-key-algorithm, --default-rsa-private-key-size, --default-ecdsa-private-key-size.
If the default values have changed, the existing certificates will not renewed immediately. Instead, the are renewed normally 30 days before they expired. The new certificates will then use the new default values if the certificate does not specify private key algorithm and size explicitly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Support deployment specific default values for private key algorithm and size with the new command line options `--default-private-key-algorithm`, `--default-rsa-private-key-size`, `--default-ecdsa-private-key-size`

@MartinWeindel MartinWeindel requested a review from a team as a code owner April 16, 2024 08:31
@gardener-robot gardener-robot added the needs/review Needs review label Apr 16, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2024
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 16, 2024
@MartinWeindel MartinWeindel added the area/ipcei IPCEI (Important Project of Common European Interest) label Apr 16, 2024
@MartinWeindel MartinWeindel merged commit 50f1d68 into master Apr 19, 2024
7 checks passed
@MartinWeindel MartinWeindel deleted the default-private-key-size branch April 19, 2024 12:07
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinWeindel @gardener-robot-ci-3 @gardener-robot