Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang v1.18 for apidiff test #410

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

acumino
Copy link
Member

@acumino acumino commented Sep 27, 2022

What this PR does / why we need it:
This PR updated apidiff test job to use golang v1.18. This is required cause there is no release available of go-apidiff which supports golang v1.19.
There is an open PR on go-apidiff side to support the new version of go joelanford/go-apidiff#19.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Sep 27, 2022
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2022
@acumino
Copy link
Member Author

acumino commented Sep 27, 2022

/kind bug

@gardener-prow gardener-prow bot added kind/bug Bug and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 27, 2022
@oliver-goetz
Copy link
Member

/approve
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2022
@gardener-prow
Copy link

gardener-prow bot commented Sep 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@gardener-prow gardener-prow bot merged commit f0566d1 into gardener:master Sep 27, 2022
@gardener-prow
Copy link

gardener-prow bot commented Sep 27, 2022

@acumino: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key gardener-apidiff.yaml using file config/jobs/gardener/gardener-apidiff.yaml

In response to this:

What this PR does / why we need it:
This PR updated apidiff test job to use golang v1.18. This is required cause there is no release available of go-apidiff which supports golang v1.19.
There is an open PR on go-apidiff side to support the new version of go joelanford/go-apidiff#19.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@acumino acumino deleted the apidiff branch January 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants