[WIP] Refactor Provider Credentials #2195
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
Highlight secret row instead of open secret dialog
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
show secret data in edit mode
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
reviewed
Nov 25, 2024
Comment on lines
+26
to
+27
| const credentialsList = secretBindings.map(secretBinding => { | ||
| const secret = referencedSecrets.find(secret => secret.metadata.name === secretBinding.secretRef.name) |
There was a problem hiding this comment.
Suggested change
| const credentialsList = secretBindings.map(secretBinding => { | |
| const secret = referencedSecrets.find(secret => secret.metadata.name === secretBinding.secretRef.name) | |
| const secretMap = new Map(referencedSecrets.map(secret => [secret.metadata.name, secret])) | |
| const credentialsList = secretBindings.map(secretBinding => { | |
| const secret = secretMap.get(secretBinding.secretRef.name) |
| return [ | ||
| { | ||
| label: 'Domain Name', | ||
| value: atob(secretData.domainName), |
There was a problem hiding this comment.
Use Base64.decode(data) instead of atob
| const gardenerExtensionStore = useGardenerExtensionStore() | ||
| const cloudProfileStore = useCloudProfileStore() | ||
|
|
||
| const credentialResourcesList = ref(null) |
There was a problem hiding this comment.
Rename to cloudProviderCredentials or cloudProviderCredentialList. I would never use Resource or Resources as part of the name. In kubernetes the term object and items is used. The term resource is use in http in the client - server context form server entities.
|
|
||
| const secretBindingList = computed(() => { | ||
| return map(credentialResourcesList.value, ({ secretBinding, secret, quotas }) => { | ||
| Object.defineProperty(secretBinding, 'secretResource', { |
| configurable: false, | ||
| enumerable: false, | ||
| }) | ||
| Object.defineProperty(secretBinding, 'quotaResources', { |
Comment on lines
+67
to
+69
| writable: false, | ||
| configurable: false, | ||
| enumerable: false, |
There was a problem hiding this comment.
This is the default. We have not specified these default value in the past
| @@ -455,14 +455,14 @@ export function shortRandomString (length) { | |||
| } | |||
|
|
|||
| export function selfTerminationDaysForSecret (secret) { | |||
| const clusterLifetimeDays = function (quotas, scope) { | |||
| return get(find(quotas, scope), ['spec', 'clusterLifetimeDays']) | |||
| const clusterLifetimeDays = function (quotaResources, scope) { | |||
|
|
||
| exports.create = async function ({ user, body }) { | ||
| const client = user.client | ||
| const { coordinate: { namespace, name }, credential: { poviderType, secretData } } = body |
There was a problem hiding this comment.
I would not use the property coordinate. Use the relevant properties flat. Pass the params and not body.
const { namespace, name, poviderType, secretData } = params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the backend
/cloudprovidersecretsAPISecretBinding,Secret(if own) and resolvedQuotaresourcesThis PR is also a preparation to support new CredentialsBinding resource
SecretBindingas the leading resource, access referenced secret only when we need to access the actual secret dataCredentialsBindingsin the backend and return with the list. The dashboard can then work with CredentialsBindings and SecretBindings in the frontend as they are more or less interchangeable. Only the reference to the Secret / WorkloadIdentity data is different so we need to add some kind of abstraction / transformation there.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Tests need to be adapted
Release note: