Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the readiness/liveness Probes configuration. #357

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

ishan16696
Copy link
Member

@ishan16696 ishan16696 commented Jun 8, 2022

What this PR does / why we need it:

  1. Adds failureThreshold to 5 for both readiness and liveness Probe.
  2. Update the livenessProbe for etcd making the consistency serializable using --consistency="s"

Which issue(s) this PR fixes:
Fixes #280 partially as there is still a room for improvement(more info)

Special notes for your reviewer:
For values of initialDelaySeconds and failureThreshold can be discussed. I'm open for change.
cc @timuthy

Release note:

livenessProbe of etcd container has been updated to `ETCDCTL_API=3 etcdctl get foo --consistency=s` making the consistency `serializable`. 
failureThreshold has been updated to `5` for both livenessProbe and readinessProbe of etcd.

@ishan16696 ishan16696 requested a review from a team as a code owner June 8, 2022 05:07
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 8, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 8, 2022
@ishan16696
Copy link
Member Author

Should we include this PR as well in our upcoming release of druid ?

cc @abdasgupta @timuthy @aaronfern

Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ishan16696. Please also add a release note so that users are aware of the change.

charts/etcd/templates/etcd-statefulset.yaml Outdated Show resolved Hide resolved
Fix the unit tests.
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 8, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 8, 2022
@ishan16696
Copy link
Member Author

Added the release note. PTAL @timuthy

Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 9, 2022
@ishan16696 ishan16696 added the merge/squash Should be merged via 'Squash and merge' label Jun 9, 2022
@ishan16696 ishan16696 merged commit 3d721af into gardener:master Jun 14, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 14, 2022
@ishan16696 ishan16696 deleted the edit-probe branch June 14, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Liveness Probe on multi-node etcd
6 participants