-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the readiness/liveness Probes configuration. #357
Conversation
Should we include this PR as well in our upcoming release of druid ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ishan16696. Please also add a release note so that users are aware of the change.
Fix the unit tests.
Added the release note. PTAL @timuthy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
failureThreshold
to 5 for both readiness and liveness Probe.serializable
using--consistency="s"
Which issue(s) this PR fixes:
Fixes #280 partially as there is still a room for improvement(more info)
Special notes for your reviewer:
For values of initialDelaySeconds and failureThreshold can be discussed. I'm open for change.
cc @timuthy
Release note: