Use JSON logger with ISO8601 time encoder for controller manager #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/logging
gardener-robot-ci-2
added
reviewed/ok-to-test
shreyas-s-rao
force-pushed
the
fix/log-encoder
branch
from
6179509
to
53415a5
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/reviewed ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
shreyas-s-rao
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
shreyas-s-rao
force-pushed
the
fix/log-encoder
branch
from
53415a5
to
c2560f2
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
unmarshall
reviewed
Feb 12, 2023
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@unmarshall thanks for your suggestion. I've incorporated it now. PTAL |
unmarshall
approved these changes
Feb 12, 2023
|
/remove needs/cherry-pick |
gardener-robot
removed
the
needs/cherry-pick
Do we have a plan to release |
aaronfern
approved these changes
Feb 14, 2023
@ishan16696 yes, that's the reason I removed the |
ishan16696
approved these changes
Feb 15, 2023
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area logging
/kind bug
/needs cherry-pick
What this PR does / why we need it:
Recently merged PR #450 bumped controller-runtime version from
v0.10.2tov0.13.0, which changed the default logging behavior for the logger provided for the controllers to print epoch timestamps in the logs which are not human-readable, as is pointed out by kubernetes-sigs/controller-runtime#2024.This PR explicitly sets the logger options to use ISO8601 timestamps for the controller logs, as well as switches the logger from dev mode to json mode, ie, structured logging, for better integration with logging stack in production environments.
Which issue(s) this PR fixes:
Fixes partially #524
Special notes for your reviewer:
/cc @unmarshall @rfranzke
Release note: