Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the zone state caches are managed per internal DNSAccount object.
A DNSAccount object is created per set of credentials as it is not possible to identify the account for all provider types.
If there are now multiple credentials for the same account, e.g. because of credentials rotation, there are multiple DNSAccount instances with separate zone state caches for the same hosted zone(s).
The updates are always executed using the account of the provider of the DNSEntry. But all these updates are performed during a zone reconciliation by comparing to a single cached zone state from one account. This can lead to phantom or missing records in this particular cache and update operations are added to "repair" the mismatches. These update operations will fail und the updates are added on the next reconciliation again until the zone state caches is synchronised periodically.
Using the newly introduced qualified zone ids, the zone state caches are now managed globally. This means there is only one zone state cache per hosted zone globally, independent of the number of DNSAccounts.
Addtionally the option to store the caches in a persistent volume has been removed, as it was never used and adjusting it to the new structure was too much effort.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: