Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic if source object referenced by a DNSAnnotation object has no annotations #363

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
This PR fixes a panic ""assignment to entry in nil map" (assignment to entry in nil map)", if a DNS source object like a service or ingress object has no own annotations, but is referenced by a DNSAnnotation object.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix panic if source object referenced by a DNSAnnotation object has no annotations in its metadata.

@MartinWeindel MartinWeindel requested a review from a team as a code owner April 3, 2024 10:54
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 3, 2024
@gardener-robot gardener-robot added the needs/review Needs review label Apr 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 3, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Apr 3, 2024
@MartinWeindel MartinWeindel merged commit a6e48ac into master Apr 3, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the fix/panic-annotation branch April 3, 2024 11:21
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants