Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude us-gov zones from alias target creation #365

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Exclude us-gov zones from alias target creation #365

merged 1 commit into from
Apr 19, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Customer reported that alias records are not supported in AWS GovCloud Route53 according to AWS technical support.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

As AWS "us-gov" zones do not support alias target records, they are excluded from the list of canonical hosted zones used to decide if `ALIAS` records are created instead of `CNAME` records.

@MartinWeindel MartinWeindel requested a review from a team as a code owner April 19, 2024 09:26
@gardener-robot gardener-robot added the needs/review Needs review label Apr 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Apr 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 19, 2024
@MartinWeindel
Copy link
Member Author

/cc @ScheererJ

@MartinWeindel MartinWeindel merged commit 4d78849 into master Apr 19, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the fix/no-aliastargets-for-us-gov branch April 19, 2024 09:52
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 19, 2024
@MartinWeindel MartinWeindel mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot