Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore annotation for DNSEntry and source resources #380

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Add ignore annotation for DNSEntry and source resources #380

merged 1 commit into from
Jul 23, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The annotation dns.gardener.cloud/ignore=true is introduced for DNSEntries to disable reconciliation temporarily.
The annotation is also available for source resources like Ingress, Service, Gateway (both Istio and Kubernetes Gateway API) and replicated DNSEntries.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add ignore annotation `dns.gardener.cloud/ignore=true` for  `DNSEntries` and source resources to disable reconciliation temporarily.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2024
@RaphaelVogel
Copy link
Member

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 22, 2024
@MartinWeindel MartinWeindel merged commit e3ff557 into master Jul 23, 2024
8 checks passed
@MartinWeindel MartinWeindel deleted the enh/ignore-annotation branch July 23, 2024 06:28
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @RaphaelVogel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot