Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge /pkg/flags into /pkg/target #296

Open
petersutter opened this issue May 10, 2023 · 1 comment
Open

Merge /pkg/flags into /pkg/target #296

petersutter opened this issue May 10, 2023 · 1 comment
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) status/blocked Issue is blocked (e.g. because of dependencies)

Comments

@petersutter
Copy link
Contributor

What would you like to be added:
Merge /pkg/flags into /pkg/target and rename target.go (within /pkg/flags) to flags.go
Also drop the unsued parameter from func RegisterCompletionFuncsForTargetFlags(cmd *cobra.Command, factory util.Factory, ioStreams util.IOStreams, _ *pflag.FlagSet) {

Why is this needed:
@petersutter petersutter added component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension labels May 10, 2023
@petersutter petersutter mentioned this issue May 10, 2023
Merged
@petersutter
Copy link
Contributor Author

/hold currently this would result in an import cycle:

pkg/target/flags.go depends on
-> internal/util (Factory, IOStreams) depends on
-> pkg/target (Manager, TargetFlags)

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label May 12, 2023
@petersutter petersutter added status/blocked Issue is blocked (e.g. because of dependencies) and removed reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels May 12, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/gardenctl Gardener CLI kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) status/blocked Issue is blocked (e.g. because of dependencies)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petersutter @gardener-robot