Add target flags to target view command
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersutter
added
the
area/ipcei
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
petersutter
force-pushed
the
enh/target/view/support-target-flags
branch
from
fdd8d9d
to
555b7c0
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
petersutter
force-pushed
the
enh/target/view/support-target-flags
branch
from
555b7c0
to
0e2cd38
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
reviewed
May 10, 2023
| @@ -35,6 +36,9 @@ func NewCmdView(f util.Factory, ioStreams util.IOStreams) *cobra.Command { | |||
|
|
|||
| o.AddFlags(cmd.Flags()) | |||
|
|
|||
| f.TargetFlags().AddFlags(cmd.Flags()) | |||
| flags.RegisterCompletionFuncsForTargetFlags(cmd, f, ioStreams, cmd.Flags()) | |||
There was a problem hiding this comment.
Not related to this PR but why do we pass the flagset to this function. It is not used. The flags must already be registered. And I think it was a very bad idea to name this package flags which always create a name conflict if you want to have variable named flags. I anyway think it should be part of the same package the TargetFlags belongs to.
There was a problem hiding this comment.
true, I have created an issue for it #296
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds target flags to the
targetviewcommand.This is beneficial when gardenctl is used within a script, and the script needs to determine the current target while also taking the target flags into account.
Which issue(s) this PR fixes:
Fixes #286
Special notes for your reviewer:
Release note: