Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply review comments. Add debug support #7

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Apply review comments. Add debug support #7

merged 8 commits into from
Mar 21, 2024

Conversation

andrerun
Copy link
Contributor

How to categorize this PR?
/area auto-scaling
/kind enhancement

What this PR does / why we need it:
Applies some of the initial review comments. Also adds debug support based on skaffold and the standard local dev setup.

Release note:

NONE

@andrerun andrerun requested a review from a team as a code owner March 15, 2024 14:03
@gardener-robot gardener-robot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 15, 2024
@andrerun andrerun requested a review from plkokanov March 15, 2024 14:04
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2024
@ialidzhikov
Copy link
Member

/assign

@gardener-robot
Copy link

@plkokanov You have pull request review open invite, please check

ialidzhikov
ialidzhikov requested changes Mar 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
pkg/ha/ha_service.go Outdated Show resolved Hide resolved
pkg/util/gardener/util.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 18, 2024
ialidzhikov
ialidzhikov reviewed Mar 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
plkokanov
plkokanov requested changes Mar 18, 2024
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
example/custom-metrics-deployment.yaml Outdated Show resolved Hide resolved
example/custom-metrics-deployment.yaml Show resolved Hide resolved
pkg/ha/ha_service.go Show resolved Hide resolved
pkg/util/gardener/util_test.go Outdated Show resolved Hide resolved
pkg/util/gardener/util_test.go Show resolved Hide resolved
skaffold.yaml Outdated Show resolved Hide resolved
skaffold.yaml Outdated Show resolved Hide resolved
@plkokanov
Copy link

/assign

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2024
ialidzhikov
ialidzhikov reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final cosmetic suggestions, rest of the changes look good as initial change.

Makefile Outdated Show resolved Hide resolved
docs/development/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@andrerun @ialidzhikov
Development README cosmetics
a322ae2 
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2024
@andrerun @ialidzhikov
README cosmetics
c5908ed 
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2024
ialidzhikov
ialidzhikov approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
plkokanov
plkokanov requested changes Mar 21, 2024
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit left

skaffold.yaml Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
ialidzhikov
ialidzhikov approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Mar 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024
plkokanov
plkokanov approved these changes Mar 21, 2024
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit ea8d8a9 into main Mar 21, 2024
11 checks passed
@ialidzhikov ialidzhikov deleted the proposed2 branch March 21, 2024 15:48
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 21, 2024
@ialidzhikov ialidzhikov mentioned this pull request Mar 22, 2024
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@plkokanov plkokanov plkokanov approved these changes

Assignees

@ialidzhikov ialidzhikov

@plkokanov plkokanov

Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@andrerun @ialidzhikov @gardener-robot @plkokanov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3