-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt NetworkPolicy
s according to recent refactorings
#162
Adapt NetworkPolicy
s according to recent refactorings
#162
Conversation
@ScheererJ Thank you for your contribution. |
This is needed for checking the cilium configmap in the cluster.
0da8f3f
to
58a0f6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need here to also set the metrics port on the svc.
We could also explicitly define the metrics port in the service. However, also other extensions do not specify the metrics port, e.g. gardener/gardener-extension-provider-aws@f028217. For extensions with a webhook usually that port is explicitly exposed. Do you want to also expose the metrics port (unlike some other extensions)? |
I looked at the calico extension and there we have explicitly exposed the port. It looked like there was something missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area dev-productivity ops-productivity networking security
/kind enhancement
What this PR does / why we need it:
This PR adapts the
NetworkPolicy
s according to the recent refactorings ingardener/gardener
See also gardener/gardener#7589 and https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller.
Which issue(s) this PR fixes:
Part of gardener/gardener#7352
Special notes for your reviewer:
/cc @rfranzke @oliver-goetz @timuthy
Depends on gardener/gardener@v1.66 to create the expected network policies in the extension namespace.
Release note: