Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the priority according to the gardener guideline #507

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Adapt the priority according to the gardener guideline #507

merged 1 commit into from
Aug 5, 2022

Conversation

krgostev
Copy link
Contributor

@krgostev krgostev commented Jul 6, 2022 •
edited
Loading

How to categorize this PR?

/area quality
/kind enhancement
/platform alicloud

What this PR does / why we need it:
This PR removes the old PriorityClass from the charts and adapt the deployment priorityClassName according to the gardener documentation. Part of #5634
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

This version of provider-alicloud requires Gardener v1.50+.

@krgostev krgostev requested review from a team as code owners July 6, 2022 12:17
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 6, 2022
@krgostev krgostev mentioned this pull request Jul 6, 2022
Closed
35 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 6, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 7, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 7, 2022
@shaoyongfeng
Copy link
Contributor

shaoyongfeng commented Jul 13, 2022 •
edited
Loading

Hi @kris94 ,
I think we also need to add priorityClassName in
https://github.com/gardener/gardener-extension-provider-alicloud/blob/master/charts/internal/seed-controlplane/charts/csi-alicloud/templates/csi-snapshot-controller.yaml
https://github.com/gardener/gardener-extension-provider-alicloud/blob/master/charts/internal/machine-controller-manager/seed/templates/deployment.yaml

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 22, 2022
@gardener-robot
Copy link

@kris94 You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 22, 2022
@krgostev
Copy link
Contributor Author

Hi @shaoyongfeng, I have adapted the csi-snapshot-controller, thanks for noticing. However, the MCM is already adapted.

@krgostev krgostev removed the needs/rebase Needs git rebase label Jul 22, 2022
@shaoyongfeng shaoyongfeng added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 26, 2022
@shaoyongfeng
Copy link
Contributor

@kris94
can you run make generate again?

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 1, 2022
@shaoyongfeng shaoyongfeng merged commit f35efe1 into gardener:master Aug 5, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review platform/alicloud Alicloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krgostev @shaoyongfeng @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2