Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace issue in webhook manifest #130

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fix whitespace issue in webhook manifest #130

merged 1 commit into from
Jul 14, 2020

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jul 14, 2020 •
edited
Loading

How to categorize this PR?

/kind bug
/priority normal
/platform gcp

What this PR does / why we need it:
#112 introduces an issue that helm template for the validator chart renders an invalid manifest for the webhook

$ helm template charts/gardener-extension-admission-gcp/charts/application/
# ...
  failurePolicy: Fail
  objectSelector: {}
  namespaceSelector: {}
  sideEffects: NonetimeoutSeconds: 10clientConfig:
    service:
      namespace: default
      name: gardener-extension-admission-gcp
      path: /webhooks/validate/secrets
# ...

With this PR:

$ helm template charts/gardener-extension-admission-gcp/charts/application/
# ...
  failurePolicy: Fail
  objectSelector: {}
  namespaceSelector: {}
  sideEffects: None
  timeoutSeconds: 10
  clientConfig:
    service:
      namespace: default
      name: gardener-extension-admission-gcp
      path: /webhooks/validate/secrets
# ...

Release note:

NONE

@ialidzhikov ialidzhikov requested review from a team as code owners July 14, 2020 09:58
@gardener-robot gardener-robot added kind/bug Bug platform/gcp Google cloud platform/infrastructure priority/normal labels Jul 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2020
@ialidzhikov
Copy link
Member Author

/size xs

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jul 14, 2020
@ialidzhikov
Fix whitespace issue in webhook manifest
967d4a1 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2020
@vpnachev
Copy link
Member

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2020
vpnachev
vpnachev approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jul 14, 2020
@ialidzhikov ialidzhikov merged commit 580f4d2 into gardener:master Jul 14, 2020
@ialidzhikov ialidzhikov deleted the fix/webhook-manifest branch July 14, 2020 11:25
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @vpnachev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot