Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PDB for admission server #153

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add PDB for admission server #153

merged 1 commit into from
Aug 11, 2020

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area high-availability robustness
/kind enhancement
/priority normal
/platform gcp

What this PR does / why we need it:
This PR adds a PodDisruptionBudget to the admission chart which will be created when the replica count is larger than 1, similar to how it's done for the extension controller.

Special notes for your reviewer:
ℹ️ We should work on #143 as soon as possible.

/invite @ialidzhikov @timuthy

Release note:

A `PodDisruptionBudget` for the admission server is now automatically deployed as part of its Helm chart if the replica count is larger than `1`.

@rfranzke rfranzke requested review from a team as code owners August 11, 2020 10:49
@gardener-robot gardener-robot added area/high-availability High availability related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review platform/gcp Google cloud platform/infrastructure priority/normal labels Aug 11, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 11, 2020
timuthy
timuthy approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 11, 2020
@ialidzhikov ialidzhikov merged commit a4bc6be into gardener:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees
No one assigned
Labels
area/high-availability High availability related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rfranzke @timuthy @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot