-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use client.Reader to prevent starting Informer for Secrets #253
Merged
timebertt
merged 1 commit into
gardener:master
from
ialidzhikov:enh/disable-secret-cache
Apr 12, 2021
Merged
Use client.Reader to prevent starting Informer for Secrets #253
timebertt
merged 1 commit into
gardener:master
from
ialidzhikov:enh/disable-secret-cache
Apr 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abb36e4
to
38d4c51
Compare
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
38d4c51
to
2bc4f7d
Compare
/assign @timebertt |
timebertt
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
platform/gcp
Google cloud platform/infrastructure
reviewed/lgtm
Has approval for merging
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/platform gcp
After #112 I think that we have only one place where we explicitly interact with Secrets. This PR replaces the usage of a cached client with a client.Reader for the corresponding call to prevent having an Informer for Secrets under the hood.
I hope that this will improve the memory usage of the admission-gcp component.Update: see #253 (comment)
Part of #143
Release note: