admission-openstack: Adapt Secrets webhook to rely on the provider label #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/area robustness
/area cost
/kind enhancement
/platform openstack
What this PR does / why we need it:
This PR:
provider.shoot.gardener.cloud/openstack="true"
Which issue(s) this PR fixes:
Part of gardener/gardener-extension-provider-gcp#143 but for admission-openstack
Special notes for your reviewer:
Unlike admission-{gcp,aws,azure} for admission-openstack we cannot drop the cache for SecretBindings as the Shoot validator has to get the SecretBinding -> then the Secret to fetch the domainName from it - the domainName is later used for validation.
gardener-extension-provider-openstack/pkg/admission/validator/shoot.go
Lines 216 to 236 in 1d8ffd8
gardener-extension-provider-openstack/pkg/admission/validator/shoot.go
Lines 120 to 122 in 1d8ffd8
Release note: