Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI migration beginning with 1.19, convert cloud-provider configmap into secret, remove zone from ControlPlaneConfig #65

Merged
merged 5 commits into from
May 28, 2020
Merged

CSI migration beginning with 1.19, convert cloud-provider configmap into secret, remove zone from ControlPlaneConfig #65

merged 5 commits into from
May 28, 2020

Conversation

rfranzke
Copy link
Member

What this PR does / why we need it:
This PR adds support for CSI (+ migration for existing clusters).
CSI will be used for 1.19 shoots. Older shoots will keep using the in-tree legacy volume provisioner.
Also, it converts the cloud-provider ConfigMap to a Secret.
Also, it removes the zone field from the ControlPlaneConfig.

Which issue(s) this PR fixes:
Fixes #1
Fixes #61

Special notes for your reviewer:
OpenStack CSI migration is still alpha with 1.18 but will be promoted to beta with 1.19. When we work on 1.19 support for OpenStack we should revisit the CSI and probably update the image versions.

Release note:

The `zone` field in the `ControlPlaneConfig` has been deprecated and will be removed in a future version. It is no longer required to set and has no effect anymore. Consider updating your deployment manifests.

The `cloud-provider-config-cloud-controller-manager` has been renamed to `cloud-provider-config` and is now a `Secret` instead of a `ConfigMap`. The `cloud-provider-config-kube-controller-manager` has been renamed to `cloud-provider-disk-config` and is now a `Secret` instead of a `ConfigMap`.

@rfranzke rfranzke requested review from a team as code owners April 17, 2020 07:45
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2020
@rfranzke rfranzke changed the title CSI migration beginning with 1.19, convert cloud-provider configmap into secret CSI migration beginning with 1.19, convert cloud-provider configmap into secret, remove zone from ControlPlaneConfig Apr 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 17, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2020
@rfranzke
Copy link
Member Author

/area storage
/kind enhancement
/priority normal
/size xl
/needs review

@ghost ghost added area/storage Storage related kind/enhancement Enhancement, improvement, extension priority/normal size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/review Needs review labels May 18, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2020
@rfranzke
Copy link
Member Author

/assign @dkistner @MartinWeindel @mandelsoft

@ialidzhikov ialidzhikov self-requested a review May 19, 2020 14:55
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 22, 2020
ialidzhikov
ialidzhikov reviewed May 22, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will play with it asap.

pkg/controller/csimigration/add.go Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Member

I will play with it asap.

I played with pvcs and volumesnapshots, it worked well.

@rfranzke rfranzke requested a review from ialidzhikov May 25, 2020 04:11
@ialidzhikov
Copy link
Member

/needs rebase

@ghost ghost added needs/rebase Needs git rebase and removed reviewed/lgtm Has approval for merging labels May 25, 2020
@rfranzke
Copy link
Member Author

/remove needs/rebase

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2020
@ghost ghost removed the needs/rebase Needs git rebase label May 26, 2020
@rfranzke rfranzke requested a review from ialidzhikov May 26, 2020 16:41
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 26, 2020
ialidzhikov
ialidzhikov previously approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added the reviewed/lgtm Has approval for merging label May 26, 2020
@rfranzke
Copy link
Member Author

Thanks @ialidzhikov!
Anybody else planning to review it? If not, I want to merge it tomorrow.

@rfranzke
Copy link
Member Author

@tim-ebert does it mean you won't review it or whether you'd want me to wait? 😄

@timebertt
Copy link
Member

Sorry, that was ambiguous.
I won’t review😅

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2020
@rfranzke
Copy link
Member Author

/merge

@ghost
Copy link

ghost commented May 28, 2020

@rfranzke Command /merge is not known.

@rfranzke rfranzke merged commit 2cc30ad into gardener:master May 28, 2020
@rfranzke rfranzke deleted the feature/csi branch May 28, 2020 04:55
@rfranzke rfranzke mentioned this pull request Jun 18, 2020
Merged
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

Assignees

@mandelsoft mandelsoft

@MartinWeindel MartinWeindel

@dkistner dkistner

Labels
area/storage Storage related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove zone from ControlPlaneConfig Adopt CSI for OpenStack extension beginning with Kubernetes 1.19
10 participants
@rfranzke @ialidzhikov @timebertt @mandelsoft @MartinWeindel @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot