Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendored gardener v1.83.3 #697

Merged
merged 2 commits into from
Dec 14, 2023
Merged

vendored gardener v1.83.3 #697

merged 2 commits into from
Dec 14, 2023

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Dec 11, 2023 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Vendor gardener/gardener =>  `v1.83.3`

@kon-angelo kon-angelo requested review from a team as code owners December 11, 2023 12:37
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure labels Dec 11, 2023
@kon-angelo
Copy link
Contributor Author

/hold

@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 11, 2023
@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 11, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 11, 2023
@kon-angelo kon-angelo changed the title vendored gardener vendored gardener v1.83.2 Dec 11, 2023
@kon-angelo
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Dec 12, 2023
shafeeqes
shafeeqes previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2023
ialidzhikov
ialidzhikov reviewed Dec 13, 2023
View reviewed changes
go.mod Outdated
github.com/gardener/gardener v1.81.6
github.com/gardener/machine-controller-manager v0.48.1
github.com/gardener/etcd-druid v0.20.1
github.com/gardener/gardener v1.83.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to update to v1.83.3? In v1.83.3 an issue in the extension library that prevents CPM for hibernated Shoots is resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapted the PR 👍

@kon-angelo kon-angelo changed the title vendored gardener v1.83.2 vendored gardener v1.83.3 Dec 13, 2023
@gardener-robot gardener-robot added needs/review Needs review needs/second-opinion Needs second review by someone else and removed needs/review Needs review labels Dec 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2023
@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Dec 13, 2023
AndreasBurger
AndreasBurger previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2023
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Dec 13, 2023
@gardener-robot
Copy link

@kon-angelo You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/review Needs review label Dec 14, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2023
AndreasBurger
AndreasBurger approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 14, 2023
@kon-angelo kon-angelo merged commit 83a3d1d into gardener:master Dec 14, 2023
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 14, 2023
@kon-angelo kon-angelo deleted the vendor/gardener branch December 14, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@AndreasBurger AndreasBurger AndreasBurger approved these changes

@shafeeqes shafeeqes shafeeqes left review comments

Assignees

@shafeeqes shafeeqes

Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else platform/openstack OpenStack platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kon-angelo @gardener-robot @AndreasBurger @ialidzhikov @shafeeqes @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3