-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/gardener/gardener to 1.86.0 #704
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | RSA Private Key | 7807196 | example/admission-openstack-certs/tls.key | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
6c1bbf7
to
e190f4e
Compare
6256749
to
f2b041b
Compare
f2b041b
to
70d0263
Compare
Since admission controllers now run the certificate controller, leader election must be enabled to prevent any interference.
This change is mostly relevant for deployments without a virtual Garden cluster: In this case, the admission controller needed cluster-wide list/watch permissions for secrets. Restricting the cache to the `--webhook-config-namespace` namespace eliminates this requirement.
70d0263
to
d1a0f2a
Compare
Address review comments from similar PR gardener/gardener-extension-networking-calico#327.
9b5bb2f
to
0f01362
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area open-source
/kind enhancement
/platform openstack
What this PR does / why we need it:
This PR updates the
github.com/gardener/gardener
dependency tov1.86.0
. As a consequence, admission CA and service certificates are now managed automatically. The vendor directory is removed as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: