use first load balancer class as default if no class with name "default" provided #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
afritzler
suggested changes
May 13, 2020
There was a problem hiding this comment.
Looks good. But we need to adjust the test case https://github.com/gardener/gardener-extension-provider-openstack/blob/master/pkg/controller/controlplane/valuesprovider_test.go#L321-L324 since we now always have the FloatingNetworkID in the config spec.
…th name default provided Co-authored-by: Uwe Krueger <uwe.krueger@sap.com>
MartinWeindel
force-pushed
the
default-floatingip-subnet
branch
from
3cbe0e7
to
c75954f
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
mandelsoft
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Uwe Krueger uwe.krueger@sap.com
What this PR does / why we need it:
If multiple load balancer classes are defined in a floating pool of the cloud profile constraints, currently the default class must be named "default". If no "default" LB class is provided, the Openstack CCM chooses one by random. With this PR the first load balancer class is used instead.
Additionally it is ensured that the floating network ID from the infrastructure is used for all LB classes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: