Deflake should enable and disable the registry-cache extension TM test

[ialidzhikov]

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
I see many failures in the should enable and disable the registry-cache extension TM test.
The reason for the failures is that in the step Disable the registry-cache extension

gardener-extension-registry-cache/test/testmachinery/shoot/enable_disable_test.go

Lines 65 to 70 in 8a088c8

	By("Disable the registry-cache extension")
	Expect(f.UpdateShoot(ctx, func(shoot *gardencorev1beta1.Shoot) error {
	common.RemoveRegistryCacheExtension(shoot)
	return nil
	})).To(Succeed())

ctx is used. However ctx is already a context of another step Wait until the registry configuration is applied:

gardener-extension-registry-cache/test/testmachinery/shoot/enable_disable_test.go

Lines 57 to 60 in 5ec3e79

	By("Wait until the registry configuration is applied")
	ctx, cancel = context.WithTimeout(parentCtx, 5*time.Minute)
	defer cancel()
	common.WaitUntilRegistryConfigurationsAreApplied(ctx, f.Logger, f.ShootClient)

After step Wait until the registry configuration is applied the step Verify registry-cache works is executed (can take up to 12mins) and currently the step Disable the registry-cache extension is executed with context that has less than 5min timeout (it can be the case that the timeout is already exceeded meanwhile during the next step execution).

This PR fixes this by creating a new context from the parentContext with timeout of 10mins for the Disable the registry-cache extension step.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
Logs proving the flake:

STEP: Enable the registry-cache extension @ 01/04/24 09:35:36.34
STEP: Wait until the registry configuration is applied @ 01/04/24 09:39:06.837
STEP: Verify registry-cache works @ 01/04/24 09:39:28.049
STEP: Create nginx Pod @ 01/04/24 09:39:28.049
STEP: Wait until nginx Pod is running @ 01/04/24 09:39:28.061
STEP: Verify the registry cache pulled the nginx image @ 01/04/24 09:39:43.095
STEP: Delete nginx Pod @ 01/04/24 09:39:43.716
STEP: Disable the registry-cache extension @ 01/04/24 09:39:48.739

[FAILED] in [It] - /src/test/testmachinery/shoot/enable_disable_test.go:70 @ 01/04/24 09:44:06.855

Note that the failure is exactly atWait until the registry configuration is applied + 5min.

Release note:

A flake in the `should enable and disable the registry-cache extension` testmachinery test is now fixed.

[plkokanov]

/lgtm

[gardener-prow]

LGTM label has been added.

Git tree hash: 98b561579b91a20518ec060834be66e2e68f2645

[dimitar-kostadinov]

/lgtm

[ialidzhikov]

/approve

[gardener-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ialidzhikov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment