Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vulnerability scans for the alpine and pause images #89

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Nov 3, 2023

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
The PR:

  • excludes alpine and pause images from vulnerability scans
  • updates alpine to 3.18.4

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
The PR depends on gardener/ci-infra#990.

Release note:

Vulnerability scans are disabled for the alpine and pause images as the corresponding containers are not accessible from outside of the K8s clusters and not interacted with from other containers or other systems.
The following image is updated:
- `eu.gcr.io/gardener-project/3rd/alpine`: 3.15.8 -> 3.18.4

Copy link
Contributor

gardener-prow bot commented Nov 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 3, 2023
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 3, 2023
@ialidzhikov ialidzhikov changed the title Skip vulnerabilities scans for the alpine and pause images Skip vulnerability scans for the alpine and pause images Nov 3, 2023
@ialidzhikov ialidzhikov marked this pull request as ready for review November 3, 2023 13:03
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@ialidzhikov
Copy link
Member Author

/approve

Copy link
Contributor

gardener-prow bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2023
Copy link
Contributor

gardener-prow bot commented Nov 4, 2023

LGTM label has been added.

Git tree hash: e2adff705dc0323f590f6a11c07e2738816b3aa5

@dimitar-kostadinov
Copy link
Contributor

/retest

@gardener-prow gardener-prow bot merged commit 635ad42 into gardener:main Nov 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants