Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test TestDefinition #45

Merged
merged 1 commit into from
May 17, 2022
Merged

Fix integration test TestDefinition #45

merged 1 commit into from
May 17, 2022

Conversation

ialidzhikov
Copy link
Member

/area testing
/kind bug

  1. Currently with golang:1.16.6 the test execution fails with:

    # sigs.k8s.io/json/internal/golang/encoding/json
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
vendor/sigs.k8s.io/json/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

    To fix the TestDefinition image is updated to go1.17.

  2. Next, the test execution failed with:

    # github.com/gardener/gardener-extension-runtime-gvisor/test/integration/suites_test [github.com/gardener/gardener-extension-runtime-gvisor/test/integration/suites.test]
test/integration/suites/run_suite_test.go:57:72: undefined: reporter.NewGardenerESReporter

    test/integration/suites/run_suite_test.go has to be adapted to fix the build failure.

Release note:

An issue causing the integration test execution to fail due to outdated golang version is now fixed.

@ialidzhikov
Fix integration test TestDefinition
360a5c2 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner May 16, 2022 13:53
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 16, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 16, 2022
This was referenced May 16, 2022
Merged
Merged
acumino
acumino approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 16, 2022
@rfranzke rfranzke merged commit 3acd474 into gardener:master May 17, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 17, 2022
@ialidzhikov ialidzhikov deleted the fix/test-definition branch May 18, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @acumino @rfranzke @gardener-robot-ci-3 @gardener-robot