Fix propagation of EFFECTIVE_VERSION during builds in pipeline #62

vpnachev · 2022-09-20T12:37:28Z

What this PR does / why we need it:
Fix propagation of EFFECTIVE_VERSION during builds in pipeline.
Also splits docker builder stage to speed-up image builds.

Which issue(s) this PR fixes:
Fixes #47

Special notes for your reviewer:
/invite @ialidzhikov

Release note:

A bug that the extension was using wrong version of the installation image when no image vector overwrite is configured is fixed.

ialidzhikov

Are you sure that it is that trivial? In the past you did a similar change in #36 and then you reverted in #39.

vpnachev · 2022-09-20T12:50:48Z

Good catch.
/hold

vpnachev · 2022-09-21T11:55:46Z

After gardener/cc-utils@2348bce, the EFFECTIVE_VERSION is set as build arg and the GitVersion is properly set.

$ docker run  --rm eu.gcr.io/gardener-project/gardener/extensions/runtime-gvisor:v0.7.0-dev-c94906ece86738c32a4558d2dba378aaa289837f-linux-amd64 --version=raw | grep -Po 'GitVersion:".*?"'
GitVersion:"v0.7.0-dev-c94906ece86738c32a4558d2dba378aaa289837f"

/title Fix propagation of EFFECTIVE_VERSION during builds in pipeline
/unhold

gardener-robot · 2022-09-21T11:55:54Z

@gardener-robot Only code owners and the author may add reviewers. Commenters may only invite themselves.

vpnachev · 2022-09-21T12:54:38Z

This arm64 build seems to take forever most of the time. It should be because no mater of the target, always the golang binaries are built or the gVisor binaries are pulled. With fdb8413, I've split the builder stage to avoid unnecessary build steps. Let's see if it will really improve.

vpnachev · 2022-09-21T13:05:12Z

Let's see if it will really improve.

For the amd64 builds there is already an improvement:

extension image build time is reduced from 90 to 60 seconds (no significant improvement for the arm64 so far)
installation image build time reduced from 90 to 14 seconds (320 to 30 seconds for arm64)

Unfortunately, it seems the arm64 builds are still prone to stuck.

ialidzhikov

Minor suggestion, otherwise lgtm.

I can confirm that the effective version is correctly injected in the controller image/binary. It also works for images build with make docker-images.

Makefile

Co-authored-by: ialidzhikov <i.alidjikov@gmail.com>

This way each target builds/installs only what it actually needs: - extension image does not pull the gVisor binaries - installation image does not build extension binaries This should speed up multiarch builds Signed-off-by: Vladimir Nachev <vladimir.nachev@sap.com>

ialidzhikov

/lgtm

Thanks for picking this ad-hoc item!

ialidzhikov · 2022-09-21T15:34:14Z

I edited the release note as follow:

+A bug that the extension was using wrong version of the installation image when no image vector overwrite is configured is fixed.
-A bug that non-released version of the extension was using wrong version of the installation image when no image vector overwrite is configured is fixed.

as it also affect released versions. We don't hit it on our landscapes because we always use imageVectorOverwrite there.

vpnachev requested a review from a team as a code owner September 20, 2022 12:37

gardener-robot requested a review from ialidzhikov September 20, 2022 12:37

gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 20, 2022

ialidzhikov reviewed Sep 20, 2022

View reviewed changes

gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 20, 2022

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

vpnachev force-pushed the ci/inject-effective-version branch from d51a96a to 01d9e6f Compare September 20, 2022 13:20

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

vpnachev force-pushed the ci/inject-effective-version branch from 01d9e6f to 7602a90 Compare September 20, 2022 13:30

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

vpnachev force-pushed the ci/inject-effective-version branch from 7602a90 to c5cee84 Compare September 20, 2022 13:47

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

vpnachev force-pushed the ci/inject-effective-version branch from c5cee84 to 39af836 Compare September 20, 2022 14:20

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

ialidzhikov added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2022

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2022

vpnachev force-pushed the ci/inject-effective-version branch from 55ecdd2 to c94906e Compare September 21, 2022 11:42

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022

gardener-robot changed the title ~~Enable effective version injection during pipeline builds~~ Fix propagation of EFFECTIVE_VERSION during builds in pipeline Sep 21, 2022

gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 21, 2022

gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 21, 2022

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022

ialidzhikov reviewed Sep 21, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

vpnachev and others added 3 commits September 21, 2022 18:21

Fix propagation of EFFECTIVE_VERSION during builds in pipeline

16ba0d2

Propagate effective version to LD_FLAGS_GENERATOR

e55be45

Co-authored-by: ialidzhikov <i.alidjikov@gmail.com>

vpnachev force-pushed the ci/inject-effective-version branch from fdb8413 to b353b3c Compare September 21, 2022 15:21

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2022

ialidzhikov approved these changes Sep 21, 2022

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 21, 2022

ialidzhikov merged commit f1c01fb into gardener:master Sep 21, 2022

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 21, 2022

vpnachev deleted the ci/inject-effective-version branch September 21, 2022 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix propagation of EFFECTIVE_VERSION during builds in pipeline #62

Fix propagation of EFFECTIVE_VERSION during builds in pipeline #62

vpnachev commented Sep 20, 2022 •

edited by ialidzhikov

Loading

ialidzhikov left a comment

vpnachev commented Sep 20, 2022

vpnachev commented Sep 21, 2022

gardener-robot commented Sep 21, 2022

vpnachev commented Sep 21, 2022

vpnachev commented Sep 21, 2022 •

edited

Loading

ialidzhikov left a comment •

edited

Loading

ialidzhikov left a comment

ialidzhikov commented Sep 21, 2022 •

edited

Loading

Fix propagation of EFFECTIVE_VERSION during builds in pipeline #62

Fix propagation of EFFECTIVE_VERSION during builds in pipeline #62

Conversation

vpnachev commented Sep 20, 2022 • edited by ialidzhikov Loading

ialidzhikov left a comment

Choose a reason for hiding this comment

vpnachev commented Sep 20, 2022

vpnachev commented Sep 21, 2022

gardener-robot commented Sep 21, 2022

vpnachev commented Sep 21, 2022

vpnachev commented Sep 21, 2022 • edited Loading

ialidzhikov left a comment • edited Loading

Choose a reason for hiding this comment

ialidzhikov left a comment

Choose a reason for hiding this comment

ialidzhikov commented Sep 21, 2022 • edited Loading

vpnachev commented Sep 20, 2022 •

edited by ialidzhikov

Loading

vpnachev commented Sep 21, 2022 •

edited

Loading

ialidzhikov left a comment •

edited

Loading

ialidzhikov commented Sep 21, 2022 •

edited

Loading