-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor gardener@1.65.0
and Upgrade k8s dependencies and controller-runtime
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade k8s dependencies to `v0.26.1` Upgrade controller-runtime to `v0.14.4`
Now we have a linter for grouping imports. Also run `make format` at the end of `make generate`.
/hold |
gardener-robot
added
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
needs/review
Needs review
labels
Mar 2, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Mar 2, 2023
gardener-robot
added
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
labels
Mar 2, 2023
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 2, 2023
shafeeqes
force-pushed
the
vendor/gardener@1.65
branch
from
March 2, 2023 05:26
32f87b7
to
c6a2ba0
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 2, 2023
shafeeqes
force-pushed
the
vendor/gardener@1.65
branch
from
March 2, 2023 06:30
8ff95a0
to
e6425c8
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 2, 2023
shafeeqes
force-pushed
the
vendor/gardener@1.65
branch
from
March 2, 2023 07:50
e6425c8
to
d34c189
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 2, 2023
Gardener now checks all the ManagedResources in the shoot controlplane which does not specify `spec.class`, so these MRs are already covered.
shafeeqes
force-pushed
the
vendor/gardener@1.65
branch
from
March 2, 2023 09:19
d34c189
to
817a29d
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Mar 2, 2023
/unhold |
gardener-robot
removed
the
reviewed/do-not-merge
Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
label
Mar 2, 2023
rfranzke
approved these changes
Mar 6, 2023
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/open-source
Open Source (community, enablement, contributions, conferences, CNCF, etc.) related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Vendor gardener
v1.65.0
Upgrade k8s dependencies and controller-runtime
Which issue(s) this PR fixes:
Special notes for your reviewer:
I have removed the health check controller, since there was only one health check for ManagedResource and condition
ShootSystemComponentsHealthy
, these are already health checked by gardener now. If you need to add some specific error code checks or add health check for some other condition, this controller shall be added again.Release note: