Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener@1.65.0 and Upgrade k8s dependencies and controller-runtime #75

Merged
merged 9 commits into from
Mar 6, 2023
Merged

Vendor gardener@1.65.0 and Upgrade k8s dependencies and controller-runtime #75

merged 9 commits into from
Mar 6, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
Vendor gardener v1.65.0
Upgrade k8s dependencies and controller-runtime

Which issue(s) this PR fixes:

Special notes for your reviewer:
I have removed the health check controller, since there was only one health check for ManagedResource and condition ShootSystemComponentsHealthy, these are already health checked by gardener now. If you need to add some specific error code checks or add health check for some other condition, this controller shall be added again.

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.59.0 -> v1.65.0
- k8s.io/* : v0.25.0 -> v0.26.1
- sigs.k8s.io/controller-runtime: v0.13.0-> v0.14.4

@shafeeqes
Vendor gardener@v1.65.0
b362655 
Upgrade k8s dependencies to `v0.26.1`
Upgrade controller-runtime to `v0.14.4`
@shafeeqes
Replace logger.ZapLogger with logger.MustNewZapLogger
6a53faf
@shafeeqes
Adapt imagevector.Read function
cfc8c10
@shafeeqes
Run make format
f13083e 
Now we have a linter for grouping imports.
Also run `make format` at the end of `make generate`.
@shafeeqes shafeeqes requested review from a team as code owners March 2, 2023 04:50
@shafeeqes
Copy link
Contributor Author

/hold

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review Needs review labels Mar 2, 2023
@shafeeqes shafeeqes mentioned this pull request Mar 2, 2023
Closed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2023
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels Mar 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2023
@shafeeqes
Remove MR health check for ShootSystemComponentsHealthy condition
451c175 
Gardener now checks all the ManagedResources in the shoot controlplane which does not specify `spec.class`, so these MRs are already covered.
@shafeeqes
Run make revendor
dadd555
@shafeeqes
Run make generate
817a29d
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2023
@shafeeqes
Copy link
Contributor Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 2, 2023
@rfranzke rfranzke merged commit 230c619 into gardener:master Mar 6, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 6, 2023
@ialidzhikov ialidzhikov mentioned this pull request Mar 6, 2023
Merged
@shafeeqes shafeeqes deleted the vendor/gardener@1.65 branch March 7, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot