Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt NetworkPolicy rules according to recent refactorings #78

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Adapt NetworkPolicy rules according to recent refactorings #78

merged 3 commits into from
Mar 8, 2023

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Mar 8, 2023 •
edited
Loading

How to categorize this PR?

/area dev-productivity ops-productivity networking security
/kind enhancement

What this PR does / why we need it:
This PR adapts the NetworkPolicy rules according to the recent refactorings in gardener/gardener
See also gardener/gardener#7589 and https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller.

Which issue(s) this PR fixes:
Part of gardener/gardener#7352

Special notes for your reviewer:
/cc @ScheererJ @oliver-goetz @rfranzke

Depends on gardener/gardener@v1.66 to create the expected network policies in the extension namespace.

Release note:

Adapted extension components to support the [FullNetworkPoliciesInRuntimeCluster](https://github.com/gardener/gardener/blob/master/docs/deployment/feature_gates.md#list-of-feature-gates) feature gate introduced by `gardener/gardener` v1.66, see [here](https://github.com/gardener/gardener/blob/master/docs/concepts/resource-manager.md#networkpolicy-controller) and [#7352](https://github.com/gardener/gardener/pull/7589) for more information.

@timuthy
Allow extension to talk to its runtime cluster
d27c473
@timuthy
Allow scraping from seed-prometheus
92eb168 
Add a new `Service` to allow connections from `seed-prometheus` to
the extension pods.
@timuthy
[make generate]
2b31ebb
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 8, 2023
@timuthy timuthy mentioned this pull request Mar 8, 2023
Closed
47 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 8, 2023
@timuthy timuthy marked this pull request as ready for review March 8, 2023 10:30
@timuthy timuthy requested review from a team as code owners March 8, 2023 10:30
rfranzke
rfranzke approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 628dca1 into gardener:master Mar 8, 2023
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 8, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 8, 2023
@timuthy timuthy deleted the enhancement.netpols branch March 9, 2023 08:27
@timuthy timuthy added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) area/ipcei IPCEI (Important Project of Common European Interest) area/networking Networking related area/ops-productivity Operator productivity related (how to improve operations) area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timuthy @rfranzke @gardener-robot-ci-3 @gardener-robot