Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taint to daemonset #81

Merged
merged 1 commit into from
May 11, 2023
Merged

Add taint to daemonset #81

merged 1 commit into from
May 11, 2023

Conversation

bd3lage
Copy link
Contributor

@bd3lage bd3lage commented May 4, 2023 •
edited by dguendisch
Loading

What this PR does / why we need it:
This will prevent Daemonset to complain about misscheduled pods found for nodes that are scheduled to be Scaledown

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added NoExecute/NoSchedule tolerations to the gvisor daemonset to prevent reporting of `misscheduled` pods on node scale-down operations.

@bd3lage bd3lage requested review from a team as code owners May 4, 2023 14:43
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 4, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 4, 2023
@bd3lage
Copy link
Contributor Author

bd3lage commented May 9, 2023 •
edited
Loading

/ping @marwinski @MrBatschner @danielfoehrKn

@gardener-robot
Copy link

@bd3lage No arguments have been provided when at least 1 is required. Please try again with as least 1 person or label

@gardener-robot
Copy link

@MrBatschner, @danielfoehrKn, @marwinski ℹ️ please take some time to help bd3lage or redirect to someone else if you can't.

MrBatschner
MrBatschner approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@MrBatschner MrBatschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 11, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2023
@MrBatschner MrBatschner merged commit 6715994 into gardener:master May 11, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrBatschner MrBatschner MrBatschner approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bd3lage @gardener-robot @MrBatschner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3