Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shoot.gardener.cloud/no-cleanup=true label to CRDs #195

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Add shoot.gardener.cloud/no-cleanup=true label to CRDs #195

merged 1 commit into from
Sep 27, 2023

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area usability
/kind bug

What this PR does / why we need it:
Add shoot.gardener.cloud/no-cleanup=true label to CRDs to avoid Gardenlet to delete CRDs and GRM recreating them.
As certificates have no infrastructure resources , it is not mandatory to delete them (or their source objects) in the shoot cluster.
Additionally reverts #194 as not needed anymore.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `CustomResourceDefinition`s deployed to shoot clusters are now labelled with `shoot.gardener.cloud/no-cleanup=true` to prevent `gardenlet` to deleting them during shoot deletion.

@MartinWeindel MartinWeindel requested review from a team as code owners September 27, 2023 13:28
@MartinWeindel
Copy link
Member Author

/cc @ScheererJ

@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2023
ScheererJ
ScheererJ approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2023
@MartinWeindel MartinWeindel merged commit 9c5e843 into master Sep 27, 2023
5 checks passed
@MartinWeindel MartinWeindel deleted the shoot-crd-no-cleanup branch September 27, 2023 13:38
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-3 @gardener-robot