Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant issuer short name #211

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Remove redundant issuer short name #211

merged 1 commit into from
Nov 2, 2023

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #208

Special notes for your reviewer:

Release note:

Remove redundant short name for `issuer` CustomResourceDefinition.

@MartinWeindel MartinWeindel requested review from a team as code owners November 2, 2023 08:14
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2023
ScheererJ
ScheererJ approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 2, 2023
@MartinWeindel MartinWeindel merged commit d5a40d9 into master Nov 2, 2023
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 2, 2023
@MartinWeindel MartinWeindel deleted the fix/remove-issuer-short-name branch November 2, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short name for Issuer CRD is invalid
5 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot