Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Shoots with Kubernetes version == 1.24 #223

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Drop support for Shoots with Kubernetes version == 1.24 #223

merged 3 commits into from
Mar 19, 2024

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:

  • Add unhealthyPodEvictionPolicy: AlwaysAllow to PDBs
  • Drop support for Shoots, Seeds and Gardens with Kubernetes version == 1.24.

Which issue(s) this PR fixes:
Part of gardener/gardener#8921
Part of gardener/gardener#8821

Special notes for your reviewer:
In draft until the gardener/gardener PR is merged and released.

Release note:

`extension-shoot-cert-service` no longer supports Shoots with Кubernetes version == 1.24.

@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 2, 2024
@shafeeqes shafeeqes mentioned this pull request Jan 2, 2024
Closed
24 tasks
@shafeeqes shafeeqes marked this pull request as ready for review March 10, 2024 16:55
@shafeeqes shafeeqes requested review from a team as code owners March 10, 2024 16:55
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 10, 2024
@shafeeqes
Copy link
Contributor Author

/invite @MartinWeindel

MartinWeindel
MartinWeindel approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@MartinWeindel MartinWeindel merged commit f344591 into gardener:master Mar 19, 2024
5 checks passed
@shafeeqes shafeeqes deleted the cleanup/k8s-1.24 branch March 19, 2024 08:24
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 19, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shafeeqes @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot