Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permissions to manage configmaps for extension service account. #262

Merged
merged 1 commit into from
May 24, 2024
Merged

Add permissions to manage configmaps for extension service account. #262

merged 1 commit into from
May 24, 2024

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind regression

What this PR does / why we need it:
This is probably a regression related to #257.

The reconciliation of the shoot-cert-service extension fails with

    description: 'Error reconciling Extension: failed deleting cert-controller-manager-observability-config
      ConfigMap: configmaps "cert-controller-manager-observability-config" is forbidden:
      User "system:serviceaccount:extension-extension-shoot-cert-service-9rzzx:gardener-extension-shoot-cert-service"
      cannot delete resource "configmaps" in API group "" in the namespace "shoot--foo--bar"'

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add permissions to manage configmaps for extension service account.

@MartinWeindel MartinWeindel requested review from a team as code owners May 24, 2024 10:10
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 24, 2024
@MartinWeindel
Copy link
Member Author

/cc @rfranzke

rfranzke
rfranzke approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 24, 2024
@MartinWeindel MartinWeindel merged commit c3250ff into master May 24, 2024
5 checks passed
@MartinWeindel MartinWeindel deleted the fix/permissions-configmaps branch May 24, 2024 11:22
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot