Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set priority class for shoot-dns-service #163

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Set priority class for shoot-dns-service #163

merged 1 commit into from
Oct 17, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
See gardener/gardener#5634 (comment)

Which issue(s) this PR fixes:
Part of gardener/gardener#5634

Release note:

`shoot-dns-server` Pod now runs with the appropriate priority set according to the following [document](https://github.com/gardener/gardener/blob/v1.57.1/docs/development/priority-classes.md).

@ialidzhikov ialidzhikov requested review from a team as code owners October 17, 2022 09:34
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2022
@ialidzhikov ialidzhikov mentioned this pull request Oct 17, 2022
Closed
35 tasks
MartinWeindel
MartinWeindel approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 17, 2022
@MartinWeindel MartinWeindel merged commit 56ea736 into gardener:master Oct 17, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2022
@ialidzhikov ialidzhikov deleted the fix/priorityclass branch October 17, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @MartinWeindel @gardener-robot-ci-2 @gardener-robot