Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang version in TestDefinition to 1.22.0 #302

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Bump golang version in TestDefinition to 1.22.0 #302

merged 2 commits into from
Mar 1, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Feb 29, 2024 •
edited
Loading

How to categorize this PR?

/kind bug

What this PR does / why we need it:
Currently the test execution fails with:

2024-02-29T12:49:15.472034131Z stderr F time="2024-02-29T12:49:15.471Z" level=info msg="capturing logs" argo=true
2024-02-29T12:49:15.476713874Z stderr F go: go.mod requires go >= 1.22.0 (running go 1.21.5; GOTOOLCHAIN=local)
2024-02-29T12:49:16.472789458Z stderr F time="2024-02-29T12:49:16.472Z" level=info msg="sub-process exited" argo=true error="<nil>"
2024-02-29T12:49:16.472830978Z stderr F time="2024-02-29T12:49:16.472Z" level=warning msg="cannot save artifact /tmp/tm/export" argo=true error="stat /tmp/tm/export: no such file or directory"
2024-02-29T12:49:16.47394268Z stderr F Error: exit status 1

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

An issue caused the test execution to fail due to outdated go version in the TestDefinition is now fixed.

@ialidzhikov ialidzhikov requested review from a team as code owners February 29, 2024 16:17
@gardener-robot gardener-robot added kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 29, 2024
MartinWeindel
MartinWeindel approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 1, 2024
@MartinWeindel MartinWeindel merged commit 0e0ef1f into gardener:master Mar 1, 2024
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2024
@ialidzhikov ialidzhikov deleted the fix/test-definition branch August 6, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot