Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error codes on deletion and no domain errors #303

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add error codes on deletion and no domain errors #303

merged 2 commits into from
Mar 4, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Mar 1, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
Add Gardener error codes on DNS deletion and "no domain matching" errors.

Which issue(s) this PR fixes:
Fixes #298 and #300

Special notes for your reviewer:

Release note:

Add Gardener error codes on DNS deletion and "no domain matching" errors.

@MartinWeindel MartinWeindel requested review from a team as code owners March 1, 2024 14:29
@gardener-robot
Copy link

@MartinWeindel Label kind/ops-productivity does not exist.

@gardener-robot gardener-robot added area/control-plane Control plane related needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 1, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2024
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Mar 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2024
@ScheererJ
Copy link
Member

@MartinWeindel Could you please check why verify fails?

Otherwise the change looks good.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 4, 2024
ScheererJ
ScheererJ approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit b299266 into master Mar 4, 2024
6 checks passed
@MartinWeindel MartinWeindel deleted the add-errorcodes branch March 4, 2024 09:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 4, 2024
@MartinWeindel MartinWeindel mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Gardener ErrorCode on DNS deletion errors
5 participants
@MartinWeindel @gardener-robot @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3