Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the priority according to the gardener guideline #22

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Adapt the priority according to the gardener guideline #22

merged 1 commit into from
Jul 7, 2022

Conversation

krgostev
Copy link

@krgostev krgostev commented Jul 7, 2022

What this PR does / why we need it:
This PR removes the old PriorityClass from the charts and adapt the deployment priorityClassName according to the gardener documentation. Part of #5634
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

This version of gardener-extension-shoot-networking-filter requires Gardener v1.50+.

@krgostev krgostev requested a review from a team as a code owner July 7, 2022 12:34
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 7, 2022
@krgostev krgostev mentioned this pull request Jul 7, 2022
Closed
35 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 7, 2022
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 7, 2022
MartinWeindel
MartinWeindel approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 37ace7b into gardener:master Jul 7, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 7, 2022
@krgostev krgostev deleted the priorityclass branch July 10, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krgostev @MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot