-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate usage of controller-runtime client #1028
Merged
timuthy
merged 1 commit into
gardener:master
from
ialidzhikov:controller-runtime-client
May 23, 2019
Merged
Propagate usage of controller-runtime client #1028
timuthy
merged 1 commit into
gardener:master
from
ialidzhikov:controller-runtime-client
May 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adracus
reviewed
May 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, otherwise very nice!
timuthy
reviewed
May 23, 2019
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
ialidzhikov
force-pushed
the
controller-runtime-client
branch
from
May 23, 2019 06:55
132d5ab
to
d1fd59a
Compare
Thank you! Applied the suggestions. |
timuthy
approved these changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ialidzhikov
pushed a commit
to ialidzhikov/gardener
that referenced
this pull request
Aug 1, 2024
* Support response content encoding * added acceptance tests * added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/king cleanup
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: