Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate usage of controller-runtime client #1028

Merged
merged 1 commit into from
May 23, 2019

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 22, 2019

What this PR does / why we need it:

  • Propagate usage of controller-runtime client
  • Update logging stack deletion to use label selector

/king cleanup

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise very nice!

pkg/operation/common/utils.go Outdated Show resolved Hide resolved
pkg/operation/common/utils.go Show resolved Hide resolved
pkg/operation/seed/seed.go Outdated Show resolved Hide resolved
pkg/operation/seed/seed.go Outdated Show resolved Hide resolved
pkg/operation/seed/seed.go Outdated Show resolved Hide resolved
pkg/operation/seed/seed.go Outdated Show resolved Hide resolved
pkg/operation/seed/seed.go Outdated Show resolved Hide resolved
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Member Author

Thank you! Applied the suggestions.

Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy timuthy merged commit 05ef00a into gardener:master May 23, 2019
@ialidzhikov ialidzhikov deleted the controller-runtime-client branch March 29, 2020 10:51
ialidzhikov pushed a commit to ialidzhikov/gardener that referenced this pull request Aug 1, 2024
* Support response content encoding

* added acceptance tests

* added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants