Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test suite #3946

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Add missing test suite #3946

merged 1 commit into from
Apr 26, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Apr 25, 2021 •
edited
Loading

/kind bug

Currently on make test-cov there is the following warning in the ouput:

[...]
testing: warning: no tests to run
coverage: 0.9% of statements
Found no test suites, did you forget to run "ginkgo bootstrap"?
[...]

The warning is coming from pkg/extensions as it defines tests but does not have a test suite. ginkgo requires each package to have a RunSpec function to be able run the tests - ref onsi/ginkgo#344.

Release note:

NONE

@ialidzhikov
Add missing test suite
a699229 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@gardener-robot gardener-robot added needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2021
@gardener gardener deleted a comment from gardener-robot Apr 25, 2021
@ialidzhikov ialidzhikov marked this pull request as ready for review April 25, 2021 14:37
@ialidzhikov ialidzhikov requested a review from a team as a code owner April 25, 2021 14:37
rfranzke
rfranzke approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 7c6b6c6 into gardener:master Apr 26, 2021
@ialidzhikov ialidzhikov deleted the fix/missing-test-suite branch May 10, 2021 14:06
@ialidzhikov ialidzhikov mentioned this pull request Mar 28, 2022
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov
Add missing test suite (gardener#3946)
3748566 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov
Add missing test suite (gardener#3946)
69a715b 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot