Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the go.mod version to go1.17 #5599

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Update the go.mod version to go1.17 #5599

merged 1 commit into from
Mar 22, 2022

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Mar 16, 2022 •
edited

/area open-source
/kind enhancement

This PR consists of:

  1. Updating the version in the go.mod file.

    -go 1.16
+go 1.17

  2. Running make revendor afterwards.

Fixes #4843

Release note:

NONE

@ialidzhikov
Update the go.mod version to go1.17
f513933 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner March 16, 2022 16:58
@rfranzke
Copy link
Member

/assign

@rfranzke
Copy link
Member

Thanks!

Can you explain why the concerns in #4822 (comment) are no longer relevant?

I didn't update the go version of the module (the one in go.mod) because to be honest I am not able to completely follow the changes to the module graph pruning. go1.17 should be able to work with go1.16 module. This is actually also how kubernetes/kubernetes upgraded to go1.17 - the go runtime version is go1.17 but the module version is still go1.16 - ref kubernetes/kubernetes#103692. So it should not be a problem if we delay to module version update to another PR.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/review labels Mar 16, 2022
@gardener-robot gardener-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2022
@ialidzhikov
Copy link
Member Author

Can you explain why the concerns in #4822 (comment) are no longer relevant?

I see that the raised concern in kubernetes/kubernetes#103692 was related to depstat and it is not something that we use in gardener/gardener - ref kubernetes/kubernetes#103692 (comment).

rfranzke
rfranzke approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/milestone v1.43

@rfranzke rfranzke merged commit 1f0c189 into gardener:master Mar 22, 2022
@gardener-robot gardener-robot added this to the v1.43 milestone Mar 22, 2022
@ialidzhikov ialidzhikov deleted the update/go-mod branch March 23, 2022 07:10
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov
Update the go.mod version to go1.17 (gardener#5599)
50bea2b 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov
Update the go.mod version to go1.17 (gardener#5599)
65b4b1c 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees

@rfranzke rfranzke

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.43
Development

Successfully merging this pull request may close these issues.

Update the go.mod version to go1.17
5 participants
@ialidzhikov @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot