Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt provider-local to use priority class gardener-system-900 #6236

Merged
merged 3 commits into from
Jul 4, 2022
Merged

Adapt provider-local to use priority class gardener-system-900 #6236

merged 3 commits into from
Jul 4, 2022

Conversation

krgostev
Copy link
Contributor

@krgostev krgostev commented Jun 29, 2022 •
edited by rfranzke
Loading

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
This PR removes the custom priority class from the provider-local charts and adapts it to use priorityClass gardener-system-900 as part of #5634
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@krgostev krgostev requested a review from timebertt June 29, 2022 08:53
@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 29, 2022
@gardener-prow gardener-prow bot requested review from ary1992 and voelzmo June 29, 2022 08:53
@krgostev krgostev mentioned this pull request Jun 29, 2022
Closed
35 tasks
@rfranzke rfranzke changed the title Adapt provider-local to use priority class gardener-system-900 Adapt provider-local to use priority class gardener-system-900 Jun 29, 2022
acumino
acumino reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provider-local mcm should also be adapted to use priority class gardener-system-300.

@rfranzke
Copy link
Member

Also, the local path provisioner (https://github.com/gardener/gardener/tree/master/charts/gardener/provider-local/internal/shoot-system-components/charts/local-path-provisioner/templates) should get the right priority class

@krgostev
Copy link
Contributor Author

@rfranzke, @timebertt

Also, the local path provisioner (https://github.com/gardener/gardener/tree/master/charts/gardener/provider-local/internal/shoot-system-components/charts/local-path-provisioner/templates) should get the right priority class

Local path provisioner is not described in the priority classes table What value should we assign to it?

@rfranzke
Copy link
Member

It is comparable to the CSI driver/controllers

acumino
acumino reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@krgostev krgostev force-pushed the provider-local/priority-class branch from 469a501 to 533b91b Compare July 4, 2022 12:45
rfranzke
rfranzke reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2022
@gardener-prow gardener-prow bot merged commit 91ee409 into gardener:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino left review comments

@rfranzke rfranzke rfranzke requested changes

@timebertt timebertt Awaiting requested review from timebertt

@ary1992 ary1992 Awaiting requested review from ary1992

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krgostev @rfranzke @acumino