Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the kube-apiserver and kube-controller-manager to use the appropriate PriorityClasses #6242

Merged

Conversation

krgostev
Copy link
Contributor

@krgostev krgostev commented Jun 29, 2022

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
This PR adapts he kube-apiserver and kube-controller-manager to use PriorityClassesgardener-system-500 and gardener-system-300 as part of #5634
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Jun 29, 2022
@gardener-prow gardener-prow bot requested review from timuthy and wyb1 June 29, 2022 13:39
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2022
@krgostev krgostev changed the title Adapt the kube-apiserver and kube-controller-manager to use the apropriate Adapt the kube-apiserver and kube-controller-manager to use the appropriate PriorityClasses Jun 29, 2022
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Jun 29, 2022
@rfranzke
Copy link
Member

Can you please fix the release note?

@krgostev
Copy link
Contributor Author

krgostev commented Jun 29, 2022

Can you please fix the release note?

The whole description was wrong as I have messed up and submitted it early.

@ary1992
Copy link
Contributor

ary1992 commented Jun 30, 2022

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@krgostev krgostev changed the title Adapt the kube-apiserver and kube-controller-manager to use the appropriate PriorityClasses Adapt the kube-apiserver and kube-controller-manager to use the appropriate PriorityClasses Jun 30, 2022
@rfranzke
Copy link
Member

I removed the release notes, IMO they are not needed

@rfranzke
Copy link
Member

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@timebertt
Copy link
Member

/skip

@gardener-prow gardener-prow bot merged commit ee3e503 into gardener:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants